Skip to content

Conversation

@0xpantera
Copy link
Contributor

No description provided.

Copy link
Owner

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Thanks. 🎉 🌮

I think it might be worth assuming that the contract exists instead of deploying on each run (but this is not blocking approval).

I was a bit confused about the transaction packing where you access input twice and then check the data field. Maybe I am unfamiliar with the TransactionRequest type, but maybe you could elaborate a bit.

Left some comments/questions inline.

@0xpantera 0xpantera force-pushed the feat/add-rust-script branch from 6095614 to 72aeecb Compare May 13, 2025 14:01
@0xpantera 0xpantera requested a review from bh2smith May 13, 2025 14:01
Copy link
Owner

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@bh2smith bh2smith merged commit 85b4305 into bh2smith:main May 14, 2025
1 check passed
@bh2smith
Copy link
Owner

Thanks for your contribution! @0xpantera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants