Skip to content

Add API delays and Hungarian translation#45

Closed
Dwokfur wants to merge 14 commits into
bhuebschen:mainfrom
Dwokfur:main
Closed

Add API delays and Hungarian translation#45
Dwokfur wants to merge 14 commits into
bhuebschen:mainfrom
Dwokfur:main

Conversation

@Dwokfur

@Dwokfur Dwokfur commented Oct 24, 2025

Copy link
Copy Markdown

Introduce delays due to API rate restriction and add Hungarian translation

@Ayuus

Ayuus commented Oct 27, 2025

Copy link
Copy Markdown

Syntax error in sensor.py, line 175, I think.

@Dwokfur

Dwokfur commented Oct 27, 2025

Copy link
Copy Markdown
Author

Syntax error in sensor.py, line 175, I think.

Ouch, there's a g left at the end of the line.

@Dwokfur

Dwokfur commented Oct 27, 2025

Copy link
Copy Markdown
Author

Dwokfur@c840cf5

@Ayuus

Ayuus commented Oct 27, 2025

Copy link
Copy Markdown

IS this PR supposed to work after implementing PR 34 (AutoDoorControl)?

@Dwokfur

Dwokfur commented Oct 27, 2025

Copy link
Copy Markdown
Author

IS this PR supposed to work after implementing PR 34 (AutoDoorControl)?

I've fixed the problem on my physical HA install and wanted to propose a solution, so I forked the main branch and created the pull request to have a discussion. Therefore I suspect it won't contain the enhancements of PR 34, nor does it have icemaker related stuff like in https://github.com/skatsavos/liebherr.

@Robbe-B

Robbe-B commented Oct 29, 2025

Copy link
Copy Markdown

@bhuebschen,
Can we merge & release this already to make the integration working again ?
Kind regards

@Ayuus

Ayuus commented Oct 29, 2025

Copy link
Copy Markdown

@bhuebschen, Can we merge & release this already to make the integration working again ? Kind regards

I would prefer having #34 merged first, as that one adds AutoDoorControl and IceMaker.

@Dwokfur

Dwokfur commented Oct 29, 2025

Copy link
Copy Markdown
Author

@bhuebschen, Can we merge & release this already to make the integration working again ? Kind regards

I would prefer having #34 merged first, as that one adds AutoDoorControl and IceMaker.

There are two sleep(3)s and a sleep(5) in that pull request, which I would also tend to increase to 30...

@Ayuus

Ayuus commented Oct 29, 2025

Copy link
Copy Markdown

@bhuebschen, Can we merge & release this already to make the integration working again ? Kind regards

I would prefer having #34 merged first, as that one adds AutoDoorControl and IceMaker.

There are two sleep(3)s and a sleep(5) in that pull request, which I would also tend to increase to 30...

I will be happy to test today:-)

Reduced sleep duration from 30 seconds to 5 seconds in multiple async functions to improve responsiveness.
Reduced sleep duration from 30 seconds to 5 seconds in multiple locations.
Removed unnecessary sleep calls in sensor setup and update methods.
Removed unnecessary sleep calls to improve performance.
@Dwokfur Dwokfur closed this by deleting the head repository Oct 29, 2025
@Dwokfur

Dwokfur commented Oct 29, 2025

Copy link
Copy Markdown
Author

@bhuebschen, Can we merge & release this already to make the integration working again ? Kind regards

I would prefer having #34 merged first, as that one adds AutoDoorControl and IceMaker.

There are two sleep(3)s and a sleep(5) in that pull request, which I would also tend to increase to 30...

I will be happy to test today:-)

Re-created my fork by first including skatsavos's icemaker/autodoor related changes and reproduced an updated pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants