maintenance: improve pyproject.toml file#356
Merged
Merged
Conversation
- add missing keys:
- authors
- keywords
- classifiers
- project.urls
- homepage
- source code
- issue tracker
- specify curl-cffi group in dependencies
- meet PEP 639 licensing requirements
- license: use SPDX license expression
- license-files: point to `LICENSE` file
Collaborator
|
Thanks for this, didn't cross my mind or anyone elses here. Thank you for the PR, merging. I can tell it doesn't change code I do review whats changed. I take it we don't need to cut a new version? If we do, I'll push one tonight. |
Contributor
Author
Yeah, for what it is you don't need to push a new version just for this change. Have a good day! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing information that is recommended in the specifications of pyproject.toml. Makes the PyPI package listing of tubeup more detailed and in line with other Python packages on there. Although it doesn't change any code, I have tested this in multiple environments (pipx, pip, pypy) and it still works.
[project]:authors(as "Bibliotheca Anonoma")keywordsclassifiers[project.urls]homepage(Links to GitHub repo)sourceissuecurl-cffigroup in dependencieslicensekey to meet PEP 639 requirementslicense: Uses SPDX license expression (GPL-3.0-or-later)license-files: Points toLICENSEfileSome further improvement could be made in a later PR / commit. Adding people in the
maintainerskey would require an email address alongside the name for it to fully work. I do not want to add people who maintain this repo into the key without consent.