[fix] resolve -p short option collision between --proxy and --password

[75ohmantenna]

Summary

The Options section in the CLI docstring assigned -p to both
--proxy and --password. Docopt resolves the conflict by taking the
first match, so -p <val> silently mapped to --proxy and the -p
alias for --password never worked.

This PR moves --proxy to -x, following the curl convention
(curl -x / curl --proxy), which frees -p for exclusive use as the
--password alias.

Changes

• Change --proxy short option from -p to -x in the CLI docstring.
• Update the README usage block to match.
• Add parser tests verifying -x sets --proxy and -p sets
  --password (and not --proxy), guarding against regression.

Breaking change

Scripts or shell aliases that passed -p <proxy-url> for proxy must
switch to -x <proxy-url> or the long form --proxy <proxy-url>.

Testing

pytest tests/ -q
flake8

Test upload

The fix does not affect functionality of TubeUp:
https://archive.org/details/youtube-1CIMGTO6aFc
https://archive.org/details/youtube-HaQiFAWxDxM

[vxbinaca]

I'm not opposed to merging this however I must ask why this is needed? You're asking us to break old functionality.

Now, my most important user, IA themselves, this wouldn't effect them because they don't need a proxy to upload, what I'm concerned about is power users who use those options. It would introduce a break in their scripts.

Another thing sort of related to this PR is I want to come back to eliminating short flags. Perhaps for now, use --password as a new alternate option so it's safe later on to kill short flags?

Nice work on test uploads it wasn't needed, but thanks.

[brandongalbraith]

@vxbinaca I like this change from a long term maintainability and usability perspective, but I agree with your points about existing scripting functionality. Perhaps we can institute a "brownout" and let folks know in the next release by raising a warning if a proxy URL is used with the -p flag, with the release after being the breaking change. Thoughts?

[vxbinaca]

Yeah. Next release let's squash short flags. Or by August.

[Andres9890]

I'm pretty sure this was made using AI
https://github.com/75ohmantenna/tubeup-75ohm/commit/90ead9b4370d5574c624a204e4eaf2001b10ee8b

[vxbinaca]

Right but the code is sound, I just don't like the approach. Let's remove short flags it's more consistent. We've adopted longer flags for --use-download-archive and --ignore-exisiting-item let's rip the band-aid off. Shorthand flags were the old way of doing things. It makes the flags more readable for issues.

So --proxy for a Proxy, and --user for Username and --pass for Password.

Edit: And his problem that caused the PR, it's real. The flags collide. I know why I didn't notice this, because I prefer to use cookies and don't use a proxy.

[vxbinaca]

I'm merging this and cutting a new version for the time being but I want to circle back to killing off short flags.

[brandongalbraith]

Thanks @vxbinaca!

[75ohmantenna]

I'm pretty sure this was made using AI

I should have included a disclaimer in the PR, my apologies. This was my first contribution to a project and I should have mentioned it. On second thought, I would have been better off opening a bug report to discuss it. I'll do better in the future.

[vxbinaca]

I don't think I'll be accepting any more AI commits, because they have questionable copyright.