Extensive rewrite and redesign going into v2 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsliacan
commented
Oct 8, 2025
Member
Author
|
BTW, let's change indentation to 4 spaces. That's the official recommendation https://peps.python.org/pep-0008/#indentation and it'll make life much easier when contributing code or making changes later. |
Member
|
I marked this as a draft since it’s not intended for merging and is only meant for discussion. |
Member
|
I'll not change to 4 spaces since we use 2 spaces consitently in all repositories. It’s a pragmatic, not dogmatic, choice and PEP 8 encourages consistency above all else. |
This reverts commit 3b1eea4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lennart's code. Creating a PR to be able to discuss it and the changes overall.