Skip to content

[BEP032] Add reach to grasp ecephys dataset#491

Open
ree-gupta wants to merge 9 commits intobids-standard:masterfrom
ree-gupta:bep032_ecephys_r2g
Open

[BEP032] Add reach to grasp ecephys dataset#491
ree-gupta wants to merge 9 commits intobids-standard:masterfrom
ree-gupta:bep032_ecephys_r2g

Conversation

@ree-gupta
Copy link
Member

@ree-gupta ree-gupta commented Apr 14, 2025 •
edited by yarikoptic
Loading

added by @yarikoptic now that #515 is merged:

@ree-gupta ree-gupta added the BEP label Apr 14, 2025
@ree-gupta ree-gupta mentioned this pull request Apr 14, 2025
Draft
@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Jun 18, 2025
Closed
22 tasks
@ree-gupta ree-gupta changed the title [BEP032] Add extracellular electrophysiology dataset for bep032 [BEP032] Add reach to grasp ecephys dataset for bep032 Jan 4, 2026
@ree-gupta ree-gupta changed the title [BEP032] Add reach to grasp ecephys dataset for bep032 [BEP032] Add reach to grasp ecephys dataset for Jan 4, 2026
@ree-gupta ree-gupta changed the title [BEP032] Add reach to grasp ecephys dataset for [BEP032] Add reach to grasp ecephys dataset Jan 4, 2026
@ree-gupta ree-gupta mentioned this pull request Jan 4, 2026
Open
@ree-gupta ree-gupta marked this pull request as ready for review January 4, 2026 16:22
@CodyCBakerPhD
Copy link

CodyCBakerPhD commented Jan 15, 2026

@ree-gupta Is this example up to date? Would you like it submitted alongside #527?

@ree-gupta
Copy link
Member Author

ree-gupta commented Jan 15, 2026

Hi @CodyCBakerPhD thank you for taking a look. I'll take another day to finalize this.

@ree-gupta ree-gupta changed the base branch from bep032 to master January 16, 2026 07:24
@ree-gupta ree-gupta changed the base branch from master to bep032 January 16, 2026 07:24
@ree-gupta
Copy link
Member Author

ree-gupta commented Jan 16, 2026

@ree-gupta Is this example up to date? Would you like it submitted alongside #527?

@CodyCBakerPhD Thanks again! this dataset is good to go, but the base branch is bep032 so I am unsure if we should clean that up or if I should change the base to master, what do you think? Please feel to take over and do the needful :)

@yarikoptic
Copy link
Contributor

yarikoptic commented Jan 16, 2026

could this branch be updated so picks up updated CI workflow and trigger validation against PR?

@CodyCBakerPhD
Copy link

CodyCBakerPhD commented Jan 16, 2026

@CodyCBakerPhD Thanks again! this dataset is good to go, but the base branch is bep032 so I am unsure if we should clean that up or if I should change the base to master, what do you think? Please feel to take over and do the needful :)

I'd change to master and submit them independently, personally

@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Jan 16, 2026
Open
TheChymera and others added 8 commits January 16, 2026 18:12
@TheChymera @JuliaSprenger @ree-gupta
Added BEP032 example dataset
a6d7133 
Co-authored-by: Julia Sprenger <julia.sprenger@rwth-aachen.de>
@TheChymera @yarikoptic @ree-gupta
Fixed JSON, better indentation
4e5e285 
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@ree-gupta
Add ecephys reach2grasp dataset
197aba8 
Adds microephys_ecephys_bep032 dataset with validation fixes:
- Renamed probes/electrodes/channels files to remove task-r2g_run-001 entities
  per BIDS schema rules (these entities not allowed for these file types)
@ree-gupta
fix: update dataset to pass validation
cced226
@ree-gupta
update to match schema changes
ddcb6da
@ree-gupta
update: review the dataset against publication
dab4cf5
@ree-gupta
rename: multielectrode grasp
8520e25
@ree-gupta
add dataset in listing
3e66503
@ree-gupta ree-gupta changed the base branch from bep032 to master January 16, 2026 17:14
@ree-gupta
Copy link
Member Author

ree-gupta commented Jan 16, 2026 •
edited
Loading

@yarikoptic @CodyCBakerPhD I updated the base branch. I don't know why the validation fails here, I validated it against the latest schema locally and it works.

Did you mean something else by "update" the branch?

edit: sorry, I did not look at the test names properly, it passes 🎉

@yarikoptic
Copy link
Contributor

yarikoptic commented Jan 16, 2026

may be it was some intermittent connection that github was spitting out some error page instead of json?

Validating dataset ds007/: Running bids-validator ds007  --config /home/runner/work/bids-examples/bids-examples/default-config.json --ignoreNiftiHeaders
SyntaxError: Unexpected token '<', "<html><hea"... is not valid JSON
    at parse (<anonymous>)
    at packageData (ext:deno_fetch/22_body.js:421:14)
    at consumeBody (ext:deno_fetch/22_body.js:274:12)
    at eventLoopTick (ext:core/01_core.js:187:7)
    at async loadSchema (file:///tmp/deno-compile-bids-validator/src/setup/loadSchema.ts:26:24)
    at async validate (file:///tmp/deno-compile-bids-validator/src/validators/bids.ts:52:18)
    at async main (file:///tmp/deno-compile-bids-validator/src/main.ts:34:24)
    at async file:///tmp/deno-compile-bids-validator/src/bids-validator.ts:3:16
error: Uncaught (in promise) Error: Failed to load schema from https://bids-specification--2307.org.readthedocs.build/en/2307/schema.json: Unexpected token '<', "<html><hea"... is not valid JSON
      throw new Error(
            ^
    at loadSchema (file:///tmp/deno-compile-bids-validator/src/setup/loadSchema.ts:34:13)
    at async validate (file:///tmp/deno-compile-bids-validator/src/validators/bids.ts:52:18)
    at async main (file:///tmp/deno-compile-bids-validator/src/main.ts:34:24)
    at async file:///tmp/deno-compile-bids-validator/src/bids-validator.ts:3:16

I have restarted all, let's see

@yarikoptic
Copy link
Contributor

yarikoptic commented Jan 16, 2026

dev-prs are all green, which is great! the others are red as expected since they are tested against released/master version(s) of BIDS and validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BEP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ree-gupta @CodyCBakerPhD @yarikoptic @TheChymera