Skip to content

Add eyetracking EEG dataset#537

Open
scott-huberty wants to merge 7 commits intobids-standard:masterfrom
scott-huberty:eyetacking_eeg
Open

Add eyetracking EEG dataset#537
scott-huberty wants to merge 7 commits intobids-standard:masterfrom
scott-huberty:eyetacking_eeg

Conversation

@scott-huberty
Copy link

@scott-huberty scott-huberty commented Jan 27, 2026

Closes #536

@effigies
Copy link
Contributor

physio.tsv and physioevents.tsv need to be gzipped, and they should be kept under 1KiB. 10 lines is long enough for the purpose of examples.

@scott-huberty
Copy link
Author

physio.tsv and physioevents.tsv need to be gzipped, and they should be kept under 1KiB. 10 lines is long enough for the purpose of examples.

Done in 8c14f30. Those files are now gzipped and under 1KiB

@scott-huberty
Copy link
Author

Hey @effigies can I bug you to run the pending workflows when you have a chance? No rush.

@scott-huberty
Copy link
Author

I was kind of (pleasantly!) surprised to see my dataset pass validation. Because for example if locally I do:

npx bids-validator@latest /path/to/bids-examples/eyetracking_binocular --config ~/path/to/bids-examples/bids-examples/default-config.json

I'll get errors like

2: [ERR] Files with such naming scheme are not part of BIDS specification.
....
./sub-01/beh/sub-01_task-FreeView_run-01_recording-eye1_physioevents.tsv.gz
Evidence: sub-01_task-FreeView_run-01_recording-eye1_physioevents.tsv.gz

I combed through run_test.sh and .githbub/workfows/validate.datasets.yml but could not figure out what is so different from my local command to that of the CI's.

@effigies (if you have time), do you have an idea of why the validator fails for me locally but passes in the CI?

@effigies
Copy link
Contributor

You're using the old validator. Use deno -A jsr:@bids/validator

@scott-huberty
Copy link
Author

You're using the old validator. Use deno -A jsr:@bids/validator

Thank you. the validator still complains about the physioevents files if I run:

deno -A jsr:@bids/validator  /path/to/bids-examples/eyetracking_binocular --config /path/to/bids-examples/default-config.json --ignoreNiftiHeaders

But using the the latest development code works (i.e. no errors, and the output matches what I see on the CI's of this PR):

# from the bids-validator repository directory
./local-run  /path/to/bids-examples/eyetracking_binocular --config /path/to/bids-examples/default-config.json --ignoreNiftiHeaders      

@effigies
Copy link
Contributor

effigies commented Mar 1, 2026

You can run deno cache --reload jsr:@bids/validator to make sure you're using the latest.

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'd bidsignored everything. I removed it, and now there are three errors:

	[ERROR] INCOMPLETE_STIMULUS_PRESENTATION StimulusPresentation metadata for the events file associated with /sub-EP10/ses-01/eeg/sub-EP10_ses-01_task-dots_run-01_recording-eye1_physio.tsv.gz
(/sub-EP10/ses-01/eeg/sub-EP10_ses-01_task-dots_run-01_events.tsv) must have ScreenDistance, ScreenOrigin,
ScreenResolution and ScreenSize fields.
		/sub-EP10/ses-01/eeg/sub-EP10_ses-01_task-dots_run-01_recording-eye1_physio.tsv.gz
	Please visit https://neurostars.org/search?q=INCOMPLETE_STIMULUS_PRESENTATION for existing conversations about this issue.
	[ERROR] TSV_COLUMN_MISSING A required column is missing
		timestamp
		/sub-EP10/ses-01/eeg/sub-EP10_ses-01_task-dots_run-01_recording-eye1_physio.tsv.gz - Required initial column 1 not found.
	Please visit https://neurostars.org/search?q=TSV_COLUMN_MISSING for existing conversations about this issue.
	[ERROR] MISSING_ONSET_COLUMN The physioevents.tsv.gz file declared a OnsetSource of timestamp, but no such column was found in /sub-EP10/ses-01/eeg/sub-EP10_ses-01_task-dots_run-01_recording-eye1_physio.tsv.gz.
		/sub-EP10/ses-01/eeg/sub-EP10_ses-01_task-dots_run-01_recording-eye1_physioevents.tsv.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add EEG-Eyetracking example dataset

2 participants