FIX: copy_to_derivative.m adds duplicate entries in dataset_description.json#805
Open
marcelzwiers wants to merge 11 commits intobids-standard:mainfrom
Open
FIX: copy_to_derivative.m adds duplicate entries in dataset_description.json#805marcelzwiers wants to merge 11 commits intobids-standard:mainfrom
marcelzwiers wants to merge 11 commits intobids-standard:mainfrom
Conversation
…cription.json Every time copy_to_derivative.m is used it appends the same GeneratedBy item. This commit checks for that
for more information, see https://pre-commit.ci
Collaborator
|
@marcelzwiers do you want to try to add a test to avoid a regression or do you want me to do it? |
Added tests for copying to derivative with duplicate and new entries.
for more information, see https://pre-commit.ci
Author
|
I added some tests but I didn't test the new test :-) |
Sorry, typo
Sorry, my computer rebooted while I was making a commit, so I messed up a bit.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time copy_to_derivative.m is called, it appends the same
GeneratedByitem to the dataset_description file. This commit checks for that.