Skip to content

No more pandas #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

TheChymera
Copy link
Collaborator

PR to track removing pandas, as described here.

The way this works is that:

  • Pandas-using functions are duplicated (e.g. make_entity_table() duplicated as _make_entity_table()) and pandas usage is incrementally reduced.
  • For each duplicated function the test suite includes a test of the form test_make_entity_table_transition() which returns an attempt at a prettified diff if the outputs of the two functions do not match.
  • The test can be run as pytest tests/test_render.py::test_make_entity_table_transition

@sappelhoff sappelhoff added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants