Skip to content

Comments

No more pandas#1263

Draft
TheChymera wants to merge 4 commits intobids-standard:masterfrom
TheChymera:no_more_pandas
Draft

No more pandas#1263
TheChymera wants to merge 4 commits intobids-standard:masterfrom
TheChymera:no_more_pandas

Conversation

@TheChymera
Copy link
Collaborator

PR to track removing pandas, as described here.

The way this works is that:

  • Pandas-using functions are duplicated (e.g. make_entity_table() duplicated as _make_entity_table()) and pandas usage is incrementally reduced.
  • For each duplicated function the test suite includes a test of the form test_make_entity_table_transition() which returns an attempt at a prettified diff if the outputs of the two functions do not match.
  • The test can be run as pytest tests/test_render.py::test_make_entity_table_transition

@sappelhoff sappelhoff added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude-from-changelog This item will not feature in the automatically generated changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants