Skip to content

SCHEMA: Add .dtseries.nii extension for resampled functional time series #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Oct 20, 2022

These show up in examples on the site, though they aren't listed in a template.

@tsalo
Copy link
Member

tsalo commented Oct 20, 2022

What about throwing in other CIFTI extensions? dscalar, ptseries, pconn, etc.

@rwblair
Copy link
Member Author

rwblair commented Oct 20, 2022

@tsalo There isn't a comprehensive list in the specification. I just added the one I saw in examples.

Where should a template for these live? (what all extensions/modalities/etc should be included?)

Dtseries reference is just before the mask header here:
https://bids-specification.readthedocs.io/en/stable/05-derivatives/03-imaging.html

@rwblair
Copy link
Member Author

rwblair commented Oct 20, 2022

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 88.39% // Head: 88.50% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (efe4d8c) compared to base (acd7fe4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1331      +/-   ##
==========================================
+ Coverage   88.39%   88.50%   +0.10%     
==========================================
  Files          11       11              
  Lines        1086     1087       +1     
==========================================
+ Hits          960      962       +2     
+ Misses        126      125       -1     
Impacted Files Coverage Δ
tools/schemacode/bidsschematools/validator.py 96.24% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines +121 to +125
funcgii:
value: .func.gii
display_name: Functional GIFTI
description: |
GIFTI surface data format file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it's possible we should be using .time.gii instead, I think we should not hold this PR up on adding .func.gii.

Suggested change
funcgii:
value: .func.gii
display_name: Functional GIFTI
description: |
GIFTI surface data format file.

Comment on lines +49 to +59
func_gifti:
$ref: rules.files.raw.func.func
entities:
$ref: rules.files.raw.func.func.entities
hemisphere: required
space: optional
density: optional
description: optional
extensions:
- .func.gii

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func_gifti:
$ref: rules.files.raw.func.func
entities:
$ref: rules.files.raw.func.func.entities
hemisphere: required
space: optional
density: optional
description: optional
extensions:
- .func.gii

@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Nov 3, 2022
@effigies effigies changed the title add .dtseries.nii for func derivs SCHEMA: Add .dtseries.nii extension for resampled functional time series Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants