Skip to content

[ENH] Allow to keep heading of admonition in PDF - #1768

Draft
Remi-Gau wants to merge 5 commits into
bids-standard:masterfrom
Remi-Gau:enh/17532
Draft

[ENH] Allow to keep heading of admonition in PDF#1768
Remi-Gau wants to merge 5 commits into
bids-standard:masterfrom
Remi-Gau:enh/17532

Conversation

@Remi-Gau

@Remi-Gau Remi-Gau commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Apr 11, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.81%. Comparing base (7073cfe) to head (4a550d4).
⚠️ Report is 60 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1768   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files          22       22           
  Lines        1693     1693           
=======================================
  Hits         1402     1402           
  Misses        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Remi-Gau

Copy link
Copy Markdown
Collaborator Author

Should only affect the PDF.

image

image

@Remi-Gau
Remi-Gau marked this pull request as ready for review April 11, 2024 12:56
@effigies

Copy link
Copy Markdown
Collaborator

I don't love how this looks, as the connection between the header and content isn't clear. Perhaps we could look into using existing pandoc tooling instead of hacking our own thing?

@Remi-Gau

Copy link
Copy Markdown
Collaborator Author

@Remi-Gau Remi-Gau added exclude-from-changelog This item will not feature in the automatically generated changelog formatting Aesthetics and formatting of the spec labels Apr 15, 2024
@effigies effigies added this to the 1.10.2 milestone Aug 27, 2025
@effigies effigies modified the milestones: 1.10.2, 1.11.0 Jan 16, 2026
@bclenet

bclenet commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

This PR can tackle this as well: #2275

@effigies
effigies marked this pull request as draft January 23, 2026 18:33
@effigies effigies modified the milestones: 1.11.0, 1.11.1 Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude-from-changelog This item will not feature in the automatically generated changelog formatting Aesthetics and formatting of the spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve admonition handling code

3 participants