fix: Update datetime definition/regex to match specification #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
approved these changes
Dec 11, 2024
Member
tsalo
left a comment
tsalo
left a comment
There was a problem hiding this comment.
It looks like we were previously allowing any timezone code. The change seems to fix that.
effigies
added
exclude-from-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1968 and bids-standard/bids-validator#131, we fail to validate timestamps with the
Z, but instead permit arbitrary 2-4 character upper-case strings. This goes against what the spec actually says.This PR narrowly brings the schema into line with the text of BIDS 1.10.0. In #2001, I propose permitting the full range of RFC3339 values to handle needs for non-zero offsets.