feat(schema): Rewrite PHENOTYPE_SUBJECTS_MISSING to run on each phenotype file #2107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on and takes advantage of #2050 to select phenotype files and compare the
participant_id
column to the dataset-globaldataset.subjects.participant_id
, which is populated fromparticipants.tsv
.This does two things for validation implementations:
Note that #2050 is not strictly required in order to use this check, as validating phenotype file names already requires us to have it as a pseudo-datatype. I do think a second use case (with more expected from BEP36) justifies moving this from implementation detail to official spec language.