[SCHEMA] Add light-sheet microscopy acquisition metadata fields - #2448
[SCHEMA] Add light-sheet microscopy acquisition metadata fields#2448kabilar wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2448 +/- ##
=======================================
Coverage 83.07% 83.07%
=======================================
Files 22 22
Lines 1696 1696
=======================================
Hits 1409 1409
Misses 287 287 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
To be clear, these are being applied to all microscopy images: bids-specification/src/schema/rules/sidecars/micr.yaml Lines 30 to 34 in ef05543 Do they apply to all, or only certain types? |
Hi @effigies, I am not sure if these metadata apply to modalities other than light-sheet microscopy (i.e. |
|
If they only apply to SPIM, then let's put them in their own table, e.g., SPIMAcquisition:
selectors:
- suffix == "SPIM"
fields:
...Then add text and a macro in the relevant section of the microscopy markdown file. |
I have pushed a commit with these updates. Thanks. |
effigies
left a comment
There was a problem hiding this comment.
Works from the BIDS side. Any SPIM users/experts want to chime in?
|
I've asked our optics team (@blankenp and @emineozeen) for a review (full disclosure: we are all collaborators of @kabilar, so not an entirely independent review). Here are their comments: Some of the proposed keys could apply to other (non-SPIM) microscopy systems:
Only one key seems SPIM-specicfic:
Other precisions:
And then question from myself, as a downstream user:
|
Here we propose adding metadata fields for light-sheet microscopy acquisition. Although these fields could fit within the
OtherAcquisitionParametersfield, we felt that it would be better to formally define these parameters alongside the broader community.cc @emineozeen @balbasty @blankenp @jimmyjam100 @ayendiki @satra