Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cast ArrayBufferLikes to ArrayBuffer in read-only contexts #167

Closed
wants to merge 1 commit into from

Conversation

effigies
Copy link
Contributor

Errors seen in #166 and confirmed in main: https://github.com/bids-standard/bids-validator/actions/runs/13376538054/job/37571236055

In all of these contexts, the buffers are read-only, so it is safe to claim additional, unused properties.

@effigies effigies force-pushed the fix/array-buffer-types branch from 2aefbe0 to c60f4ce Compare February 20, 2025 22:47
@effigies
Copy link
Contributor Author

@nellh or @rwblair Does this look reasonable, or should we do something more correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant