Landing page #725

julia-pfarr · 2025-10-01T22:23:29Z

I made a first draft for the modified landing page. Please give input on

color
content
spacing and other details

Also, since I am not super skilled with html, please review the code and refactor. I guess there's also a lot in the code that is actually not needed/used or could be simplified. I didn't do a proper code review in the end because I am just happy that I got this far at all :-D

I am also imagining some nice figure between the "in a nutshell" and the "stats" section, does anyone have an idea?

📚 Documentation preview 📚: https://bids-website--725.org.readthedocs.build/en/725/

…ding_page

for more information, see https://pre-commit.ci

…pfarr/bids-website into landing_page

julia-pfarr · 2025-10-01T22:33:15Z

I don't know why it doesn't show the background image and the images in the sponsors section, it works in my local build

effigies · 2025-10-01T22:39:47Z

https://bids-website--725.org.readthedocs.build/en/assets/img/logos/NIH.png instead of https://bids-website--725.org.readthedocs.build/en/725/assets/img/logos/NIH.png

Not sure how to fix that...

effigies

Possibly just:

docs/overrides/home.html

Co-authored-by: Chris Markiewicz <[email protected]>

julia-pfarr · 2025-10-01T22:46:14Z

nice, this worked, thanks @effigies

Remi-Gau

Did a quick first pass

Remi-Gau · 2025-10-02T06:39:58Z

mkdocs.yml

-        - includes/abbreviations.md
+        - includes/mkdocs.md


are you sure about this one?

I don't think mkdocs.md exist and if we do not point to this:
https://github.com/bids-standard/bids-website/blob/main/includes/abbreviations.md?plain=1

We lose links and abbreviations "tool-tips" that are defined for the whole website.

no, not sure about this one :-D not sure about any of what I did haha

.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

.github/PULL_REQUEST_TEMPLATE/website.md

Remi-Gau · 2025-10-02T06:51:23Z

docs/assets/img/logos/BIDS_logo_black.svg

not a big fan of ducplicating files that we can already exist from the specification sudmodule, maybe just copy it during the build process? or symlink to it?

Ok, I haven't been working with submodules that much, so didn't know about that. Will change.

@Remi-Gau I tried it with the submodule, but the logo doesn't show in the preview. Could you make a suggestion for how to solve this?

Remi-Gau · 2025-10-02T07:14:21Z

docs/overrides/home.html

+    </div>
+  </section>
+
+  <!-- Stats/Social proof section -->


I think for those we could maybe add links to the other relevant sections of the website

You mean that if I click on "2000+ public datasets", for example, it should direct me to the "Datasets" section of our BIDS website?

yes exactly

docs/overrides/home.html

docs/stylesheets/extra.css

docs/index.md

Remi-Gau · 2025-10-02T07:37:59Z

docs/stylesheets/extra.css

wonder if we could use scss to make it easier to navigate the css overall, seems that mkdocs material does it but it is not mentioned in the mkdocs so I figure we may have to generate the css at build time

https://github.com/squidfunk/mkdocs-material/blob/master/src/overrides/assets/stylesheets/custom.scss

Maybe make a new issue/PR for this? I've never done it so it could take some time and since the current solution works, we could go with that for now

Remi-Gau · 2025-10-02T07:39:52Z

docs/stylesheets/extra.css

+  margin-left: 0 !important;
+}
+
+/* Mobile adjustments */


I think there are some issues with the look on tablet and mobile but I would leave this kind of tweaking to a follow up PR.

to make the review easier we could keep all the @media adjustements for a follow up PR

Yes, good idea. And yes, I haven't been paying attention to tablet and phone adjustments, just focused on keeping the stuff going for laptop

christinerogers

Love it. 👏
I'd go with blue or green for easier on the eyes, but no objection to the red if everyone loves it.

…to landing_page

julia-pfarr

fix navigation sidebars

docs/stylesheets/extra.css

…to landing_page

julia-pfarr · 2025-11-26T21:05:43Z

@ericearl @bclenet @christinerogers I think I addressed all your comments now, could you please check? If yes, @christinerogers could you approve because you clicked "request changes" so merging is blocked until you approve ;-)

bclenet · 2025-11-27T09:50:14Z

Hi @julia-pfarr,
I just realized that the two links I suggested (for contributors and BIDS apps) should not be used as is because they are consistent on https://bids.neuroimaging.io/ only (not on the PR previews for example). I'll make a new review accordingly.

bclenet

Two fixes for the contributors and bids apps links on landing page.

docs/overrides/home.html

Co-authored-by: Boris Clénet <[email protected]>

Remi-Gau · 2025-11-29T15:44:14Z

unresolving some discussions to create my own TODO list

Remi-Gau · 2025-11-29T16:17:23Z

Makefile

copy the logo from the spec during the build

Remi-Gau · 2025-11-29T16:27:23Z

docs/stylesheets/extra.css

-    --mri: #a6cee3;
-    --pet: #1f78b4;
-    --micr: #33a02c;
-    --meeg: #6a3d9a;
-    --beh: #fb9a99;
-    --nirs: #b2df8a;
-    --motion: #e31a1c;
-    --mrs: #fdbf6f;
-    --unused2: #ff7f00;
-    --unused3: #cab2d6;
-    --unused4: #ffff99;
-    --unused5: #b15928;
-    --key: #e41a1c;
-    --label: #377eb8;
-    --suffix: #4daf4a;
-    --ext: #984ea3;
-    --underscore: #ff7f00;


we need to keep those otherwise we lose the colors on in several places in the getting starting guide:

in this PR:

on main:

Remi-Gau · 2025-11-29T16:38:52Z

docs/stylesheets/extra.css

we should add some formating to css because it's harder to track changes otherwise: for a later PR

Remi-Gau · 2025-11-29T16:41:22Z

mkdocs.yml

    - content.code.copy
    - content.tabs.link
    - content.tooltips
-    - footnotes


move to the extension section (it's not a feature)

Remi-Gau · 2025-11-29T16:56:07Z

mkdocs.yml

gonna move most of those changes to a separate PR because I think that even if some of them can be useful I think the vast majority are orthogonal to the goal of the current PR

Remi-Gau · 2025-11-29T17:44:51Z

there are a few contrast issues with the color chosen: will try to tweak to improve

checking contrast on firefox: open the developer tools -> click Accessibility in the developer tools menu -> finally select 'contrast' in the 'check issue' dropdown.

especially in dark mode

EDIT

after fixing

Remi-Gau and others added 8 commits January 9, 2025 18:12

[DATALAD] Recorded changes

fc33deb

first updates to landing page

98ac33a

Merge branch 'main' of github.com:bids-standard/bids-website into lan…

b3da874

…ding_page

resolve merge conflict

08f3732

first modifications for landing page

f5b8ce4

[pre-commit.ci] auto fixes from pre-commit.com hooks

e76dd7d

for more information, see https://pre-commit.ci

remove minify plugin; not needed

c5aea7f

Merge branches 'landing_page' and 'landing_page' of github.com:julia-…

1dc57ae

…pfarr/bids-website into landing_page

julia-pfarr requested review from astewartau, bendhouseart, effigies and yarikoptic October 1, 2025 22:33

effigies reviewed Oct 1, 2025

View reviewed changes

docs/overrides/home.html Outdated Show resolved Hide resolved

docs/overrides/home.html Outdated Show resolved Hide resolved

Apply suggestions from code review

9c46d4d

Co-authored-by: Chris Markiewicz <[email protected]>

Remi-Gau reviewed Oct 2, 2025

View reviewed changes

christinerogers reviewed Oct 2, 2025

View reviewed changes

julia-pfarr and others added 10 commits October 15, 2025 16:14

first modifications based on review

86bcd37

Merge branch 'landing_page' of github.com:julia-pfarr/bids-website in…

5fb71e1

…to landing_page

Merge branch 'main' into landing_page

e5cbc5c

change logo path

6ff0239

Merge branch 'landing_page' of github.com:julia-pfarr/bids-website in…

407cfb2

…to landing_page

Merge branch 'main' into landing_page

03b285f

modify landing page according to code review

3bebffb

adjust heights and spaces

faa7c4c

adjust spacing in feature boxes

5d6d36b

adjust mobile specs

e705068

julia-pfarr commented Nov 26, 2025

View reviewed changes

docs/stylesheets/extra.css Show resolved Hide resolved

julia-pfarr and others added 3 commits November 26, 2025 20:56

fix navigation sidebars

450f141

change link for logo

68ba06d

Merge branch 'landing_page' of github.com:julia-pfarr/bids-website in…

dd3f5a7

…to landing_page

bclenet reviewed Nov 27, 2025

View reviewed changes

docs/overrides/home.html Outdated Show resolved Hide resolved

docs/overrides/home.html Outdated Show resolved Hide resolved

julia-pfarr and others added 2 commits November 27, 2025 16:40

Apply suggestions from code review

25c92f7

Co-authored-by: Boris Clénet <[email protected]>

Merge branch 'main' into landing_page

c0949f2

Remi-Gau mentioned this pull request Nov 29, 2025

[MAINT] rework PR templates #749

Open

Remi-Gau added 3 commits November 29, 2025 16:54

rm pr template changes

1f7d49d

rm logo and copy from spec on build

a19cc22

format with djlint

30a6b94

Remi-Gau reviewed Nov 29, 2025

View reviewed changes

Makefile

Copy link

Contributor

Remi-Gau Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy the logo from the spec during the build

julia-pfarr reacted with heart emoji

revert config changes

0e79749

Remi-Gau reviewed Nov 29, 2025

View reviewed changes

Remi-Gau added 5 commits November 29, 2025 17:29

revert

51c6d5f

mv

982c828

mv

db05f11

comment

68502f4

mv

7835a8c

Remi-Gau reviewed Nov 29, 2025

View reviewed changes

docs/stylesheets/extra.css

Copy link

Contributor

Remi-Gau Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add some formating to css because it's harder to track changes otherwise: for a later PR

Remi-Gau reviewed Nov 29, 2025

View reviewed changes

Remi-Gau mentioned this pull request Nov 29, 2025

[ENH] add several mkdocs features #750

Open

evert

3e2ed8d

Remi-Gau added 2 commits November 29, 2025 18:44

fix contrast

eeb8368

improve dark mode contrast

34978ff

Landing page #725

Are you sure you want to change the base?

Landing page #725

Uh oh!

Conversation

julia-pfarr commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julia-pfarr commented Oct 1, 2025

Uh oh!

effigies commented Oct 1, 2025

Uh oh!

effigies left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

julia-pfarr commented Oct 1, 2025

Uh oh!

Remi-Gau left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christinerogers left a comment

Choose a reason for hiding this comment

Uh oh!

julia-pfarr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

julia-pfarr commented Nov 26, 2025

Uh oh!

bclenet commented Nov 27, 2025

Uh oh!

bclenet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Remi-Gau commented Nov 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julia-pfarr commented Oct 1, 2025 •

edited

Loading

Remi-Gau commented Nov 29, 2025 •

edited

Loading