Conversation
for more information, see https://pre-commit.ci
…pfarr/bids-website into landing_page
|
I don't know why it doesn't show the background image and the images in the sponsors section, it works in my local build |
julia-pfarr
requested review from
astewartau,
bendhouseart,
effigies and
yarikoptic
https://bids-website--725.org.readthedocs.build/en/assets/img/logos/NIH.png instead of https://bids-website--725.org.readthedocs.build/en/725/assets/img/logos/NIH.png Not sure how to fix that... |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
|
nice, this worked, thanks @effigies |
There was a problem hiding this comment.
wonder if we could use scss to make it easier to navigate the css overall, seems that mkdocs material does it but it is not mentioned in the mkdocs so I figure we may have to generate the css at build time
There was a problem hiding this comment.
Maybe make a new issue/PR for this? I've never done it so it could take some time and since the current solution works, we could go with that for now
docs/stylesheets/extra.css
Outdated
| margin-left: 0 !important; | ||
| } | ||
|
|
||
| /* Mobile adjustments */ |
There was a problem hiding this comment.
I think there are some issues with the look on tablet and mobile but I would leave this kind of tweaking to a follow up PR.
There was a problem hiding this comment.
to make the review easier we could keep all the @media adjustements for a follow up PR
There was a problem hiding this comment.
Yes, good idea. And yes, I haven't been paying attention to tablet and phone adjustments, just focused on keeping the stuff going for laptop
christinerogers
left a comment
christinerogers
left a comment
There was a problem hiding this comment.
Love it. 👏
I'd go with blue or green for easier on the eyes, but no objection to the red if everyone loves it.
Co-authored-by: Boris Clénet <117362283+bclenet@users.noreply.github.com>
|
unresolving some discussions to create my own TODO list |
There was a problem hiding this comment.
copy the logo from the spec during the build
| --mri: #a6cee3; | ||
| --pet: #1f78b4; | ||
| --micr: #33a02c; | ||
| --meeg: #6a3d9a; | ||
| --beh: #fb9a99; | ||
| --nirs: #b2df8a; | ||
| --motion: #e31a1c; | ||
| --mrs: #fdbf6f; | ||
| --unused2: #ff7f00; | ||
| --unused3: #cab2d6; | ||
| --unused4: #ffff99; | ||
| --unused5: #b15928; | ||
| --key: #e41a1c; | ||
| --label: #377eb8; | ||
| --suffix: #4daf4a; | ||
| --ext: #984ea3; | ||
| --underscore: #ff7f00; |
There was a problem hiding this comment.
we need to keep those otherwise we lose the colors on in several places in the getting starting guide:
in this PR:
on main:
There was a problem hiding this comment.
we should add some formating to css because it's harder to track changes otherwise: for a later PR
| - content.code.copy | ||
| - content.tabs.link | ||
| - content.tooltips | ||
| - footnotes |
There was a problem hiding this comment.
move to the extension section (it's not a feature)
There was a problem hiding this comment.
gonna move most of those changes to a separate PR because I think that even if some of them can be useful I think the vast majority are orthogonal to the goal of the current PR
|
there are a few contrast issues with the color chosen: will try to tweak to improve checking contrast on firefox: open the developer tools -> click Accessibility in the developer tools menu -> finally select 'contrast' in the 'check issue' dropdown. especially in dark mode 
EDIT after fixing 
|
6 participants
I made a first draft for the modified landing page. Please give input on
Also, since I am not super skilled with html, please review the code and refactor. I guess there's also a lot in the code that is actually not needed/used or could be simplified. I didn't do a proper code review in the end because I am just happy that I got this far at all :-D
I am also imagining some nice figure between the "in a nutshell" and the "stats" section, does anyone have an idea?
📚 Documentation preview 📚: https://bids-website--725.org.readthedocs.build/en/725/