Conversation
Collaborator
Author
|
I would say we hold off on this until we have developed benchmarks that justify the potential added complexity |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
==========================================
+ Coverage 83.46% 83.48% +0.02%
==========================================
Files 38 38
Lines 4305 4311 +6
Branches 1096 1098 +2
==========================================
+ Hits 3593 3599 +6
Misses 514 514
Partials 198 198
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #948 and #942
Instead of relying on looping over entities, allow the core logic of
.getto return a subquery, rather than list of files.This subquery can then be used to find the unique entities of a given target for a list files, in pure SQL.
This can a bit faster (22ms vs 6-7 ms on my test dataset w/ ~80 subs), which could make a difference on very large datasets.