ENH: Parallel specification of next API#999
Open
effigies wants to merge 3 commits intobids-standard:mainfrom
Open
ENH: Parallel specification of next API#999effigies wants to merge 3 commits intobids-standard:mainfrom
effigies wants to merge 3 commits intobids-standard:mainfrom
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 38 38
Lines 4290 4290
Branches 1100 1100
=======================================
Hits 3579 3579
Misses 515 515
Partials 196 196 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying out some Protocols to start on #989 and get some feedback.
The goal is to shift this into
bids, but for right now it's easier to use a separate package.Some initial notes:
get()back, but ensuring it only ever returns files.Datasetinstead ofLayout. I think that will help make a cleaner mental break, and could allow us to have both implementations in parallel for a while.