feat: Add Context type generators from schema #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2. Still needs tests.
I got distracted on this by some bidsschematools refactorings. As it stands, attempting to import
bids_validator.types.context
takes some 500-600ms, around 80% of that is spent loading and dereferencing the YAML schema, and another 10% on loading the jsonschema package.jsonschema
an optional dependency.In the long term, I would like to move this into
bidsschematools
, and generate static types on build, rather than at runtime, but this should let us move ahead.