[codex] Improve article link visibility - #211
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 Walkthroughウォークスルー
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: private package registry requires authentication. Disable ESLint in CodeRabbit settings or use public packages. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28f97b26fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .article-body a:not(.heading-anchor), | ||
| .note-body a:not(.heading-anchor) { | ||
| color: #111; | ||
| text-decoration: none; | ||
| color: #a83822; | ||
| text-decoration: underline; |
There was a problem hiding this comment.
Preserve Amazon card link styling
In posts or notes containing ::amazon embeds, the generated card title and CTA are also plain <a> elements, so this broader selector now matches them. Its specificity (.article-body a:not(...)) is higher than the later .amazon-card__title and .amazon-card__cta rules, which means the new red color and underline override the card/button styles on every Amazon embed; please exclude card links here or make the card rules at least as specific.
Useful? React with 👍 / 👎.
Summary
Why
Inline links in individual article bodies were styled like normal text until hover, making them hard to discover while reading. The root cause was
text-decoration: noneon shared Markdown body links.Validation
prettier --check apps/astro-blog/src/app.csspnpm --filter astro-blog lintNote: the normal
pnpmshim failed withmise ERROR cannot find binary path, so validation used the existing mise-managedpnpm.exedirectly.