Skip to content

Added newely designed icons #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jan 22, 2025
Merged

Added newely designed icons #341

merged 28 commits into from
Jan 22, 2025

Conversation

nitinprojects
Copy link
Contributor

@nitinprojects nitinprojects commented Jan 17, 2025

Fixes #338
Fixes #339
Fixes #340
Fixes #342

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 17, 2025 06:53 Inactive
@nitinprojects nitinprojects added the patch Releases small requests or bug fixes. label Jan 17, 2025
@nitinprojects
Copy link
Contributor Author

@praveen-murali-ind _a Please review.

Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitinprojects _a Please review all newly added icon names. Ensure they are typo-free and adhere to our established naming conventions. Icon names should be as compact and generic as possible to facilitate reuse across multiple scenarios.

Issues

  • Rename AgentSatus.svg to AgentStatus.svg.
  • Rename MobileAndAesktopApps.svg to MobileAndDesktopApps.
  • Rename WeeklyTimesheet Verifications.svg to Timesheet Verifications.svg.

@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 20, 2025 06:20 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 20, 2025 09:51 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 20, 2025 10:00 Inactive
@nitinprojects
Copy link
Contributor Author

@praveen-murali-ind _a I have made the changes, Please check again.

Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitinprojects _a

source/icons/AgentStatus.svg

This icon is already present.

Screenshot 2025-01-20 at 8 13 02 PM

Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitinprojects _a I have checked and noticed that some icons are already present in the library. Please cross-check.

@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 21, 2025 14:54 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 21, 2025 16:30 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 21, 2025 16:40 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 21, 2025 16:40 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 21, 2025 16:43 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 21, 2025 17:44 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 21, 2025 18:13 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 22, 2025 05:16 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 22, 2025 07:07 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 22, 2025 07:16 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 22, 2025 07:17 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-odpi-pr-341 January 22, 2025 08:23 Inactive
@nitinprojects
Copy link
Contributor Author

@praveen-murali-ind _a I have made the changes, please check again.

Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitinprojects LGTM. ❤️🎉

@praveen-murali-ind praveen-murali-ind merged commit 503f867 into main Jan 22, 2025
@praveen-murali-ind praveen-murali-ind deleted the 338-update-icons branch January 22, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
2 participants