Skip to content

Support dark mode in Typeface logos #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Support dark mode in Typeface logos #351

merged 1 commit into from
Mar 13, 2025

Conversation

praveen-murali-ind
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind commented Mar 13, 2025 •
edited
Loading

Description

Change

  • Made the Typeface logos theme-compatible by adding the necessary data attributes to target them via CSS.

After

Screenshot 2025-03-13 at 5 58 49 PM

Before

Image

Checklist

  • I have made corresponding changes to the documentation.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@praveen-murali-ind _a

@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-ojvd-pr-351 March 13, 2025 12:36 Inactive
@praveen-murali-ind praveen-murali-ind added the patch Releases small requests or bug fixes. label Mar 13, 2025
@praveen-murali-ind
Copy link
Contributor Author

@AbhayVAshokan _a Please review.

@AbhayVAshokan
Copy link
Member

Closing and reopening the PR to trigger a fresh deployment. Enabled the Create review apps for newly opened PRs option in NeetoDeploy.

@AbhayVAshokan AbhayVAshokan reopened this Mar 13, 2025
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-ojvd-pr-351 March 13, 2025 13:04 Inactive
@neetodeploy neetodeploy bot had a problem deploying to neeto-icons-ojvd-pr-351 March 13, 2025 13:09 Failure
@AbhayVAshokan
Copy link
Member

@praveen-murali-ind _a: Deployment can be accessed here. LGTM!

https://neeto-icons-ojvd-pr-351.neetodeployapp.com/

@praveen-murali-ind praveen-murali-ind merged commit 9e567a2 into main Mar 13, 2025
1 check passed
@praveen-murali-ind praveen-murali-ind deleted the 350-support-for-dark-mode branch March 13, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@praveen-murali-ind praveen-murali-ind

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for dark mode
2 participants
@praveen-murali-ind @AbhayVAshokan