Skip to content

Add integration icons #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 5, 2025
Merged

Add integration icons #363

merged 6 commits into from
Apr 5, 2025

Conversation

nitinprojects
Copy link
Contributor

@nitinprojects nitinprojects commented Apr 3, 2025 •
edited
Loading

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-ojvd-pr-363 April 3, 2025 15:35 Inactive
@nitinprojects nitinprojects added frontend Deals with React/JS code majorly. It can also include UI fixes without the help of the UI team. patch Releases small requests or bug fixes. labels Apr 3, 2025
@nitinprojects nitinprojects self-assigned this Apr 3, 2025
@neetodeploy neetodeploy bot had a problem deploying to neeto-icons-ojvd-pr-363 April 3, 2025 17:43 Failure
@nitinprojects
Copy link
Contributor Author

@praveen-murali-ind _a Please review.

@praveen-murali-ind praveen-murali-ind added the on-hold The reason should be specified as a comment before putting the issue/PR on-hold. label Apr 4, 2025
@neetodeploy neetodeploy bot had a problem deploying to neeto-icons-ojvd-pr-363 April 4, 2025 06:41 Failure
@praveen-murali-ind
Copy link
Contributor

@AbhayVAshokan _a Could you please work on the prop changes as discussed?

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned nitinprojects Apr 4, 2025
@neetodeploy neetodeploy bot had a problem deploying to neeto-icons-ojvd-pr-363 April 4, 2025 07:19 Failure
@AbhayVAshokan
Copy link
Member

Changes are done: https://abhay-ashokan.neetorecord.com/watch/8d91c14077d109c15a9a

@nitinprojects _a Let's add that height, width, and size can be configured for the Misc icons in the documentation.

@neetogit-bot neetogit-bot bot assigned nitinprojects and unassigned AbhayVAshokan Apr 4, 2025
@neetodeploy neetodeploy bot had a problem deploying to neeto-icons-ojvd-pr-363 April 4, 2025 07:25 Failure
@neetodeploy neetodeploy bot requested a deployment to neeto-icons-ojvd-pr-363 April 4, 2025 08:47 In progress
@neetodeploy neetodeploy bot temporarily deployed to neeto-icons-ojvd-pr-363 April 4, 2025 09:12 Inactive
@nitinprojects
Copy link
Contributor Author

@AbhayVAshokan _a I have updated the README.

Whenever I use <Razorpay width={100} />, the default height of 32px is applied instead of 24px. Can you check this?

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned nitinprojects Apr 4, 2025
@AbhayVAshokan
Copy link
Member

@nitinprojects _a https://abhay-ashokan.neetorecord.com/watch/98e28d6b49ff1e4633ac

@neetogit-bot neetogit-bot bot assigned nitinprojects and unassigned AbhayVAshokan Apr 4, 2025
@nitinprojects
Copy link
Contributor Author

@AbhayVAshokan _A As discussed <Razorpay width={100} /> is working fine, Please merge this.

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned nitinprojects Apr 4, 2025
@nitinprojects nitinprojects removed the on-hold The reason should be specified as a comment before putting the issue/PR on-hold. label Apr 4, 2025
@AbhayVAshokan AbhayVAshokan merged commit 6358e69 into main Apr 5, 2025
@AbhayVAshokan AbhayVAshokan deleted the 362-add-integration-icons branch April 5, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveen-murali-ind praveen-murali-ind praveen-murali-ind left review comments

Assignees

@AbhayVAshokan AbhayVAshokan

Labels
frontend Deals with React/JS code majorly. It can also include UI fixes without the help of the UI team. patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Integration icons under Misc Icons
3 participants
@nitinprojects @praveen-murali-ind @AbhayVAshokan