feat: show avatar tiles for participants without a camera#34
Open
JoVictorNunes wants to merge 1 commit into
Open
feat: show avatar tiles for participants without a camera#34JoVictorNunes wants to merge 1 commit into
JoVictorNunes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds avatar tiles to the Picture-in-Picture view for participants without an active camera, complementing the webcams already shown. This way every participant in the meeting stays visible in PiP, even those not sharing video.
Changes
USERS_SUBSCRIPTION(queries.ts): fetches users withisSharingCamera = false, ordered by name (limited to 10), includingavatar,color, and talking state (voice.talking).useUsershook (hooks.ts): exposes the subscription viauseCustomSubscription.AvatarItemcomponent (avatar-item.tsx): renders the user's avatar image or, when missing, a circle with the name initial and the user's color. Uses aResizeObserverto hide the name when the tile gets narrow (< 140px).AvatarMediatype in theGridMediaunion; avatars are appended to the webcams (tiles = [...webcams, ...avatars]) across all scenarios (screenshare, slide, slide loading, and default)..pip-avatar-itemand.pip-avatar-circleclasses, anavatar-pulseanimation, and a blue border to indicate the talking user. Container background adjusted from#000to#111.How to test
Closes Issue(s)
Closes none
Motivation