Refactor text rendering for tldraw2#71
Merged
Merged
Conversation
With tldraw2, there's a new set of fonts, the standard font sizes have changed, line spacing has changed, and the properties used to indicate text alignment and the size of text boxes have changed as well. The text rendering code has been adjusted to be more flexible for handling line height and alignment, and many of the tldraw2 specific shapes that use text are updated to have correct rendering. Some changes have been made regarding using the correct colours for tldraw2 shapes, but this is not yet complete. Support for shape opacity has been updated to align with the tldraw rendering. This PR does not fix the issues with line thickness in shape rendering. The current shape rendering used in geo shapes is based on the old tldraw1 rendering code, and needs to be rewritten to match the actual tldraw2 rendering.
26 tasks
Contributor
Author
|
Here's some images to show the differences. Old bbb-presentation-video: Reference rendering (in-browser tldraw): New bbb-presentation-video: |
Member
|
Looks much better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With tldraw2, there's a new set of fonts, the standard font sizes have changed, line spacing has changed, and the properties used to indicate text alignment and the size of text boxes have changed as well.
The text rendering code has been adjusted to be more flexible for handling line height and alignment, and many of the tldraw2 specific shapes that use text are updated to have correct rendering.
Some changes have been made regarding using the correct colours for tldraw2 shapes, but this is not yet complete. Support for shape opacity has been updated to align with the tldraw rendering.
This PR does not fix the issues with line thickness in shape rendering. The current shape rendering used in geo shapes is based on the old tldraw1 rendering code, and needs to be rewritten to match the actual tldraw2 rendering.
Fixes #67