feat: add senderRole to useLoadedChatMessages - #281
Open
GuiLeme wants to merge 1 commit into
Open
Conversation
…hat messages hook (it remains static throughout the meeting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
senderRoletouseLoadedChatMessagesExposes the sender's role as it was at the moment the message was sent. Unlike the role available through
useUsersBasicInfo/useLoadedUserList, this value is static: it does not change if the user is promoted/demoted later, and it survives the user leaving the meeting.If you have suggestions for additional properties that should be included, feel free to leave a comment below.
This could be useful for addressing security concerns related to message authenticity. For example, if a user leaves the session and all we have is their userId (the previous scenario), we have no reliable way to determine whether a message was originally sent by a moderator.
Changes
LoadedChatMessagegainssenderRole: string | null:Fixed the chat example in the README, which referenced
msg.senderName— a field that does not exist onLoadedChatMessage.Why nullable
senderRoleisnullfor system messages (welcome message, moderator-only message, chat-cleared), which have no sender:ChatMessageDAO.insertSystemMsginserts withsenderRole = Nonebbb_schema.sqldeclares"senderRole" varchar(20)with noNOT NULLThese messages are returned by the same chat page query, so plugins will see them.
More
PR Closely related: bigbluebutton/bigbluebutton#25539