-
Notifications
You must be signed in to change notification settings - Fork 267
Release v3.0.19 #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alangecker
wants to merge
25
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release v3.0.19 #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Html5 safari builds #348
update bbb-build container tag
This still listed old (now removed) containers and missed newly added ones, which are now fixed. This also makes the network_mode: host listings consistent, and removes the "extra_hosts" listed for nginx (this does not really seem to have much advantage in docs, unlike a list of allocated IP addresses which *is* useful). The list is slightly reordered to match the order in docker-compose.tmpl.yml.
This is not really needed, nginx is always intended to be behind a reverse proxy, so it can just expose its ports on the internal network. This prevents having the 4808x ports exposed externally (though a user can still expose them explicitly with a ports directive if needed). This removes the "nginx" extra-hosts definition from the bbb-graphql-middleware host container, since the "nginx" name now resolves to the nginx internal IP normally. In the haproxy config, this updates the IP address instead of using the "nginx" name, as it seems that the haproxy resolv.conf does not list the docker resolver but somehow uses the (host system) external DNS directly. Nginx also listens on port 8185. Previously this bound to 127.0.0.1 and 10.7.7.1 (the host-side IP of the internal network) explicitly, presumably to prevent this port being available publically, but this is no longer needed, so now it can just bind to the port directly.
This is not really needed, haproxy only needs to expose two ports externally, so better to make that explicit using a ports directive, which also gives the user more control.
These directories were marked as volumes in their dockerfile, but nothing was explicitly mounted on them. This makes docker create an unnamed volume and mount that when the container is created, which means that on every down/up cycle, it would leave two unnamed volumes lingering around. Explicitly mounting these data directories prevents this.
…be able to use external services
…e across docker-compose, office-convert.sh, etherpad-export.sh, and sample.env
Add restart policy to HAProxy container
feat(bbb-docker): Add enable switches for **Collabora** and **Coturn** + make Collabora URL configurable
Add missing volume mounts for coturn and redis
fixed a dependency issue which led to an error during build
BigBlueButton v3.0.19
Stop using network_mode: host for nginx and haproxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matthijskooijman #370
#369