refactor(login): B2B-4930 Extract currentCustomerJWT fetch into a sha…#930
Draft
bc-arezoo wants to merge 1 commit into
Draft
refactor(login): B2B-4930 Extract currentCustomerJWT fetch into a sha…#930bc-arezoo wants to merge 1 commit into
bc-arezoo wants to merge 1 commit into
Conversation
…red helper Centralise the customer JWT fetch/persist logic that was duplicated across loginInfo and (incoming in #927) the Login page. Adds a single validity chokepoint (isCustomerJwtValid) so callers don't repeat the check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bc-vasu
reviewed
Jun 22, 2026
| return ''; | ||
| }); | ||
|
|
||
| return jwt ?? ''; |
Contributor
There was a problem hiding this comment.
[Change]
return jwt ?? isCustomerJwtValid ('');
Contributor
There was a problem hiding this comment.
Let's address isCustomerJwtValid in a separate PR. Keeping PRs small and focused makes us easier to understand and review.
bc-veer
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…red helper
Centralise the customer JWT fetch/persist logic that was duplicated across loginInfo and (incoming in #927) the Login page. Adds a single validity chokepoint (isCustomerJwtValid) so callers don't repeat the check.
Jira: JIRA_TOKEN
What/Why?
Rollout/Rollback
Testing