fix(core): pass searchParams when swapping locales#2362
Merged
Conversation
🦋 Changeset detectedLatest commit: 354f4e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jorgemoya
force-pushed
the
fix-locales-search-params
branch
from
June 3, 2025 17:16
0a6d232 to
354f4e7
Compare
jordanarldt
approved these changes
Jun 3, 2025
matthewvolk
approved these changes
Jun 3, 2025
chanceaclark
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Noticed that when we switch locales, we lose the search params selection. In some cases (like compare and PDP), we want search params to be retained.
Testing
Locally tested that the search params remain.
Migration
Modify
useSwitchLocalehook to includeObject.fromEntries(searchParams.entries()).