Translate search button on NotFound page#2366
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: cd44815 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jorgemoya
approved these changes
Jun 3, 2025
jordanarldt
force-pushed
the
ja/add-not-found-translations
branch
from
June 3, 2025 19:30
0f6cf60 to
cd44815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
When writing e2e tests, I noticed that the "Search" button on the 404 page is not translated.
Testing
Tested locally via production build.
Migration
"search"translation key in the"NotFound"translationscore/vibes/soul/sections/not-found/index.tsx, add actaLabelproperty and ensure it is used in place of the "Search" textcore/app/[locale]/not-found.tsx, pass thectaLabelprop as the new translation keyctaLabel={t('search')}