Remove unused search props, add missing search translations#2367
Merged
Conversation
🦋 Changeset detectedLatest commit: ea81df3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jordanarldt
force-pushed
the
ja/fix-search-translations
branch
from
June 3, 2025 20:15
1115528 to
49a2589
Compare
matthewvolk
approved these changes
Jun 3, 2025
jordanarldt
force-pushed
the
ja/fix-search-translations
branch
from
June 3, 2025 20:31
49a2589 to
ea81df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
When writing e2e tests, I found more missing translations with the Search component. This PR removes some unused props and adds the missing translations.
Testing
Tested locally
Migration
core/components/header/index.tsxEnsure the following props are passed to the
HeaderSectionnavigation prop:core/messages/en.jsonAdd the following keys to the
Components.Header.Searchtranslations:core/vibes/soul/primitives/navigation/index.tsxCopy all changes from this file:
searchSubmitLabel?: string;property, ensure it is passed intoSearchFormSearchForm, remove thesearchCtaLabel = 'View more',property, as it is unused, and renamesubmitLabeltosearchSubmitLabelSearchFormpassessearchSubmitLabelto theSearchButton:<SubmitButton loading={isPending} submitLabel={searchSubmitLabel} />searchCtaLabelproperty from theSearchResultscomponent