fix(core): prefix anonymous cookie with __Secure for https://#2381
Merged
Conversation
🦋 Changeset detectedLatest commit: f371b13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
chanceaclark
force-pushed
the
fix/secure-cookie
branch
from
June 6, 2025 15:57
41562d7 to
0d26b23
Compare
chanceaclark
force-pushed
the
fix/secure-cookie
branch
2 times, most recently
from
June 6, 2025 16:27
bfb236c to
a942c34
Compare
chanceaclark
force-pushed
the
fix/secure-cookie
branch
from
June 6, 2025 19:33
a942c34 to
b96dd3f
Compare
chanceaclark
force-pushed
the
fix/secure-cookie
branch
from
June 6, 2025 19:41
b96dd3f to
f371b13
Compare
chanceaclark
marked this pull request as ready for review
June 6, 2025 19:41
jkanive
reviewed
Jun 6, 2025
Contributor
Author
|
Since I merged the anonymous session stuff 2 days ago and we haven't tagged a release yet, I wouldn't be too worried about it breaking any sessions. Theoretically yeah it could wipe an existing cart away if someone already pulled that code in. |
jkanive
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
This adds the
__Secure-cookie prefix to the anonymous session cookie to add extra security measures. This logic follows the same behavior as Auth.js does for prefixing it's cookies with the__Secure-prefix.Testing
Local dev
Production
Migration
If you haven't merge the anonymous session code, pulling it in should just work ™️.