Skip to content

Fix switch component labels for tailwind 3 #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordanarldt merged 1 commit into from
Jun 6, 2025
Merged

Fix switch component labels for tailwind 3 #2383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions core/vibes/soul/form/switch/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ export const Switch = ({
const hasLabel = label != null && label !== '';

return (
<div className="group/switch flex items-center gap-2">
<div
className="group/switch flex items-center gap-2"
data-state={checked ? 'checked' : 'unchecked'}
>
{(labelPosition === 'left' || labelPosition === 'both') && hasLabel && (
<SwitchLabel
id={id}
Expand Down Expand Up @@ -101,7 +104,7 @@ interface LabelProps {

function SwitchLabel({ id, label, size = 'medium', state, loading }: LabelProps) {
const baseClass =
'group-has-data-disabled/switch:[&:not([data-loading])]:text-contrast-400 font-semibold select-none';
'group-data-[disabled]/switch:[&:not([data-loading])]:text-contrast-400 font-semibold select-none';
const sizeClass = {
small: 'text-sm',
medium: 'text-base',
Expand Down Expand Up @@ -136,7 +139,7 @@ function SwitchLabel({ id, label, size = 'medium', state, loading }: LabelProps)
<div className="leading-[0]">
<label
className={clsx(
'group-has-data-[state=checked]/switch:block group-has-data-[state=unchecked]/switch:invisible mb-[-2px] leading-[0]',
'mb-[-2px] leading-[0] group-data-[state=unchecked]/switch:invisible group-data-[state=checked]/switch:block',
baseClass,
sizeClass,
)}
Expand All @@ -147,7 +150,7 @@ function SwitchLabel({ id, label, size = 'medium', state, loading }: LabelProps)
</label>
<label
className={clsx(
'group-has-data-[state=checked]/switch:invisible group-has-data-[state=unchecked]/switch:block mt-[-1px] leading-[0]',
'mt-[-1px] leading-[0] group-data-[state=checked]/switch:invisible group-data-[state=unchecked]/switch:block',
baseClass,
sizeClass,
)}
Expand Down