Skip to content

fix(core): add missing error styles for inputs with errors#2384

Merged
jorgemoya merged 1 commit into
canaryfrom
add-border-color-inputs
Jun 6, 2025
Merged

fix(core): add missing error styles for inputs with errors#2384
jorgemoya merged 1 commit into
canaryfrom
add-border-color-inputs

Conversation

@jorgemoya

Copy link
Copy Markdown
Contributor

What/Why?

Add missing border style for Input, NumberInput and DatePicker.

Testing

Screenshot 2025-06-06 at 2 00 34 PM

Migration

Following convention, add these conditional classes to the fields using clsx:

{
light:
    errors && errors.length > 0
    ? 'border-[var(--input-light-border-error,hsl(var(--error)))]'
    : 'border-[var(--input-light-border,hsl(var(--contrast-100)))]',
dark:
    errors && errors.length > 0
    ? 'border-[var(--input-dark-border-error,hsl(var(--error)))]'
    : 'border-[var(--input-dark-border,hsl(var(--contrast-500)))]',
}[colorScheme],

@jorgemoya
jorgemoya requested a review from a team June 6, 2025 19:11
@changeset-bot

changeset-bot Bot commented Jun 6, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3ddde64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 6, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2025 7:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jun 6, 2025 7:12pm
catalyst-au ⬜️ Ignored (Inspect) Jun 6, 2025 7:12pm
catalyst-uk ⬜️ Ignored (Inspect) Jun 6, 2025 7:12pm

@hunterbecton hunterbecton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jorgemoya
jorgemoya added this pull request to the merge queue Jun 6, 2025
Merged via the queue into canary with commit edda0e3 Jun 6, 2025
10 checks passed
@jorgemoya
jorgemoya deleted the add-border-color-inputs branch June 6, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants