fix(core): use tailwind aspect-ratio plugin#2387
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 30b74ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jordanarldt
approved these changes
Jun 6, 2025
hunterbecton
reviewed
Jun 9, 2025
hunterbecton
reviewed
Jun 9, 2025
hunterbecton
left a comment
hunterbecton
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I just had one quick comment to fix. Thank you!
chanceaclark
force-pushed
the
fix/aspect-ratio-1
branch
from
June 9, 2025 15:57
748338a to
0865a49
Compare
chanceaclark
force-pushed
the
fix/aspect-ratio-1
branch
from
June 9, 2025 15:58
0865a49 to
30b74ae
Compare
chanceaclark
enabled auto-merge
June 9, 2025 15:59
chanceaclark
added a commit
that referenced
this pull request
Jun 10, 2025
This reverts commit 96c5182.
chanceaclark
added a commit
that referenced
this pull request
Jun 10, 2025
This reverts commit 96c5182.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Utilizes the tailwind plugin to support aspect ratios in older browsers like Safari 14.
Testing
Migration
All the old arbitrary classes will need to define the height and width classes: