Skip to content

chore: update @makeswift/runtime version#2528

Closed
fikrikarim wants to merge 2 commits into
integrations/makeswiftfrom
pirates/preview-url
Closed

chore: update @makeswift/runtime version#2528
fikrikarim wants to merge 2 commits into
integrations/makeswiftfrom
pirates/preview-url

Conversation

@fikrikarim

Copy link
Copy Markdown
Member

What/Why?

Testing

Migration

@changeset-bot

changeset-bot Bot commented Aug 19, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: df5a169

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 19, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
catalyst-b2b Ready Ready Preview Comment Aug 20, 2025 2:14pm
catalyst-canary Ready Ready Preview Comment Aug 20, 2025 2:14pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
catalyst Ignored Ignored Aug 20, 2025 2:14pm
catalyst-au Ignored Ignored Aug 20, 2025 2:14pm
catalyst-uk Ignored Ignored Aug 20, 2025 2:14pm

<ReactRuntimeProvider previewMode={previewMode} runtime={runtime}>
<ReactRuntimeProvider
apiOrigin={process.env.NEXT_PUBLIC_MAKESWIFT_API_ORIGIN}
appOrigin={process.env.NEXT_PUBLIC_MAKESWIFT_APP_ORIGIN}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since apiOrigin and appOrigin are only applicable internally, I wouldn't expose them by default.

Comment thread core/next.config.ts

const withMakeswift = createWithMakeswift();
const withMakeswift = createWithMakeswift({
appOrigin: process.env.NEXT_PUBLIC_MAKESWIFT_APP_ORIGIN,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@fikrikarim

Copy link
Copy Markdown
Member Author

See #2546

@fikrikarim fikrikarim closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants