Skip to content

fix(reviews): default button label for review form#2757

Merged
matthewvolk merged 1 commit into
canaryfrom
CATALYST-1636-default-button-label
Dec 10, 2025
Merged

fix(reviews): default button label for review form#2757
matthewvolk merged 1 commit into
canaryfrom
CATALYST-1636-default-button-label

Conversation

@matthewvolk

Copy link
Copy Markdown
Contributor

What/Why?

Adds a default value for the formButtonLabel prop in the reviews section components to prevent missing button labels.

Changes:

  • Sets default formButtonLabel to 'Write a review' in both Reviews and ReviewsEmptyState
  • Passes formButtonLabel from Reviews to ReviewsEmptyState (was missing)

This ensures the review form button always displays a label, even when formButtonLabel isn't provided.

Testing

Before

catalyst-1636-before

After

catalyst-1636-after

Migration

If you've customized the Reviews or ReviewsEmptyState components in core/vibes/soul/sections/reviews/index.tsx:

  • No action required if you already pass formButtonLabel explicitly — your custom label will continue to work.
  • If you weren't passing formButtonLabel and want a different default, pass formButtonLabel explicitly with your preferred text.
  • The default is 'Write a review'. If you want a different default, override it in your implementation.

Note: This pull request description was generated with the assistance of AI.

@matthewvolk
matthewvolk requested a review from a team December 9, 2025 22:12
@changeset-bot

changeset-bot Bot commented Dec 9, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 91e7ddb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Dec 9, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
catalyst-b2b Ready Ready Preview Comment Dec 9, 2025 10:12pm
catalyst-canary Ready Ready Preview Comment Dec 9, 2025 10:12pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
catalyst Ignored Ignored Dec 9, 2025 10:12pm
catalyst-uplift-vertex Ignored Ignored Dec 9, 2025 10:12pm

@matthewvolk
matthewvolk added this pull request to the merge queue Dec 10, 2025
Merged via the queue into canary with commit 3f0fbb9 Dec 10, 2025
14 checks passed
@matthewvolk
matthewvolk deleted the CATALYST-1636-default-button-label branch December 10, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants