fix(catalyst): Update data-disabled selectors to data-[disabled]#2821
Merged
Conversation
🦋 Changeset detectedLatest commit: a684daa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jordanarldt
force-pushed
the
fix/fix-data-disabled-classes
branch
from
January 12, 2026 22:19
65609c6 to
1736063
Compare
jordanarldt
force-pushed
the
fix/fix-data-disabled-classes
branch
from
January 12, 2026 22:20
1736063 to
a684daa
Compare
jordanarldt
marked this pull request as ready for review
January 12, 2026 22:20
jorgemoya
approved these changes
Jan 12, 2026
jamesqquick
pushed a commit
that referenced
this pull request
Feb 11, 2026
chanceaclark
pushed a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
When working on my other work, I noticed that certain components weren't showing their disabled state correctly. This is due to the tailwind selectors not being correct.
To fix this, all
data-disabled:selectors must be updated todata-[disabled]Testing
Manual testing
Before fix
The "Share" menu item is disabled, but the UI is not reflecting it other than the cursor not hovering:
Screen.Recording.2026-01-12.at.4.12.15.PM.mov
After fix:
The disabled "Share" menu item is shown as expected:
Screen.Recording.2026-01-12.at.4.17.28.PM.mov
Migration
Updated Tailwind CSS class selectors from
data-disabled:todata-[disabled]:in the following components:vibes/soul/form/button-radio-group/index.tsxvibes/soul/form/card-radio-group/index.tsxvibes/soul/form/radio-group/index.tsxvibes/soul/form/rating-radio-group/index.tsxvibes/soul/form/swatch-radio-group/index.tsxvibes/soul/form/switch/index.tsxvibes/soul/primitives/dropdown-menu/index.tsxIf you have customized any of these components, update your class names:
This change ensures proper styling of disabled states using the correct Tailwind CSS data attribute syntax.