fix(core): add root level not-found page#2832
Closed
jorgemoya wants to merge 5 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 9b01795 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 22, 2026 20:28
b1fc3b8 to
8389145
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 22, 2026 20:46
8389145 to
383b842
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 23, 2026 17:30
383b842 to
d5d17a2
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 23, 2026 18:22
d5d17a2 to
de73925
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 17:17
de73925 to
4640fb7
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 18:37
4640fb7 to
8492c4d
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 18:49
8492c4d to
8afd1c8
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 19:29
8afd1c8 to
621ae1e
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 19:44
621ae1e to
73df79c
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 19:49
73df79c to
3a975a7
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 19:56
3a975a7 to
a51cd21
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 20:03
a51cd21 to
9a05308
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 20:24
9a05308 to
5a11bc4
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 26, 2026 20:38
5a11bc4 to
cb8f7f3
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 27, 2026 21:40
b11e582 to
ba2615d
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
2 times, most recently
from
January 27, 2026 21:56
31b0bf6 to
4866acd
Compare
jorgemoya
changed the title
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 27, 2026 21:56
4866acd to
c8b05e1
Compare
jorgemoya
changed the title
jorgemoya
marked this pull request as ready for review
January 27, 2026 21:59
chanceaclark
approved these changes
Jan 27, 2026
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 27, 2026 23:27
67ec047 to
98cd3d4
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 28, 2026 15:32
22bbb55 to
5435f7d
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 28, 2026 15:38
5435f7d to
aa57d6c
Compare
jorgemoya
force-pushed
the
catalyst-689-404-fix
branch
from
January 28, 2026 15:43
aa57d6c to
7ab601a
Compare
Contributor
Author
|
Closing until we get a response from Vercel on how to manage this in a better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Adds a root level
core/app/not-found.tsxthat redirects to our catch all route, which in turns renders thecore/app/[locale]/not-found.tsx.This is to circumvent the issue that
/404is handled by Vercel in the edge and looks for anot-foundpage at the root level.Testing
Migration
Add new
core/app/not-found.tsxpage.