Skip to content

feat: enables client-side navigation in Makeswift builder#2913

Merged
parthshahp merged 1 commit into
integrations/makeswiftfrom
aleksey/makeswift-builder-client-side-navigation
Jun 9, 2026
Merged

feat: enables client-side navigation in Makeswift builder#2913
parthshahp merged 1 commit into
integrations/makeswiftfrom
aleksey/makeswift-builder-client-side-navigation

Conversation

@agurtovoy

@agurtovoy agurtovoy commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What/Why?

Enables client-side navigation in Makeswift builder by upgrading Catalyst to the latest Makeswift runtime.

Testing

Kapture.2026-05-19.at.14.33.41.mp4

Migration

N/A

@vercel

vercel Bot commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
catalyst Ready Ready Preview, Comment Jun 8, 2026 6:44pm

Request Review

@changeset-bot

changeset-bot Bot commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 587f9f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-makeswift Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

agurtovoy
agurtovoy commented Mar 9, 2026
View reviewed changes
Comment thread core/package.json Outdated
@agurtovoy agurtovoy mentioned this pull request Mar 9, 2026
Merged
@agurtovoy
agurtovoy force-pushed the aleksey/makeswift-builder-client-side-navigation branch from 4f1d31a to 22c8123 Compare March 9, 2026 17:03
jorgemoya
jorgemoya approved these changes Mar 9, 2026
View reviewed changes

@jorgemoya jorgemoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include a changeset?

@jorgemoya

jorgemoya commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tagging with do not merge until we have that released runtime version.

Edit: nevermind, it's a draft PR 🤦

@agurtovoy
agurtovoy force-pushed the aleksey/makeswift-builder-client-side-navigation branch from 22c8123 to 6981c20 Compare May 18, 2026 19:09
@github-actions

github-actions Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Size Report

Comparing against baseline from bcd87c3 (2026-06-08).

Metric Baseline Current Delta
Total JS 695 kB 703.9 kB +8.9 kB (+1.3%)

Per-Route First Load JS

Route Baseline Current Delta
/(default)/(auth)/change-password/page 608.4 kB 611.3 kB +2.9 kB (+0.5%)
/(default)/(auth)/login/forgot-password/page 607.5 kB 610.4 kB +2.9 kB (+0.5%)
/(default)/(auth)/login/page 608.1 kB 611 kB +2.9 kB (+0.5%)
/(default)/(auth)/register/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/(faceted)/brand/[slug]/page 614.3 kB 617.2 kB +2.9 kB (+0.5%)
/(default)/(faceted)/category/[slug]/page 622.5 kB 625.5 kB +3 kB (+0.5%)
/(default)/(faceted)/search/page 614.3 kB 617.2 kB +2.9 kB (+0.5%)
/(default)/[...rest]/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/account/addresses/page 612 kB 614.9 kB +2.9 kB (+0.5%)
/(default)/account/orders/[id]/page 607.1 kB 610 kB +2.9 kB (+0.5%)
/(default)/account/orders/page 608 kB 610.9 kB +2.9 kB (+0.5%)
/(default)/account/settings/page 611.5 kB 614.4 kB +2.9 kB (+0.5%)
/(default)/account/wishlists/[id]/page 616.7 kB 619.6 kB +2.9 kB (+0.5%)
/(default)/account/wishlists/page 611.5 kB 614.4 kB +2.9 kB (+0.5%)
/(default)/blog/[blogId]/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/blog/page 610.2 kB 613.1 kB +2.9 kB (+0.5%)
/(default)/cart/page 616.1 kB 619 kB +2.9 kB (+0.5%)
/(default)/compare/page 610.8 kB 613.7 kB +2.9 kB (+0.5%)
/(default)/gift-certificates/balance/page 611.3 kB 614.2 kB +2.9 kB (+0.5%)
/(default)/gift-certificates/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/gift-certificates/purchase/page 611.2 kB 614.1 kB +2.9 kB (+0.5%)
/(default)/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/product/[slug]/page 622.6 kB 625.5 kB +2.9 kB (+0.5%)
/(default)/webpages/[id]/contact/page 612.6 kB 615.6 kB +3 kB (+0.5%)
/(default)/webpages/[id]/normal/page 610 kB 612.9 kB +2.9 kB (+0.5%)
/(default)/wishlist/[token]/page 613.5 kB 616.4 kB +2.9 kB (+0.5%)
/maintenance/page 606 kB 609 kB +3 kB (+0.5%)
/_not-found/page 560.6 kB 563.5 kB +2.9 kB (+0.5%)

Threshold: 5% increase. Routes with ⚠️ exceed the threshold.

@github-actions

github-actions Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Unlighthouse Performance Comparison — Vercel

Comparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores.

Summary Score

Aggregate score across all categories as reported by Unlighthouse.

Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Score 87 90 90 91

Category Scores

Category Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Performance 69 77 67 79
Accessibility 91 91 91 95
Best Practices 100 100 100 100
SEO 89 89 100 89

Core Web Vitals

Metric Prod Desktop Prod Mobile Preview Desktop Preview Mobile
LCP 5.3 s 6.2 s 5.5 s 5.6 s
CLS 0 0 0.001 0
FCP 1.2 s 1.1 s 1.2 s 1.2 s
TBT 20 ms 30 ms 20 ms 20 ms
Max Potential FID 80 ms 80 ms 80 ms 80 ms
Time to Interactive 6.6 s 8.0 s 6.7 s 5.7 s

Full Unlighthouse report →

@agurtovoy
agurtovoy force-pushed the aleksey/makeswift-builder-client-side-navigation branch from 6981c20 to adda536 Compare May 19, 2026 18:04
@agurtovoy
agurtovoy force-pushed the aleksey/makeswift-builder-client-side-navigation branch from adda536 to 7aff6ac Compare May 19, 2026 18:13
agurtovoy
agurtovoy commented May 19, 2026
View reviewed changes
Comment thread core/package.json
"@conform-to/zod": "^1.6.1",
"@icons-pack/react-simple-icons": "^11.2.0",
"@makeswift/runtime": "0.26.4",
"@makeswift/runtime": "0.28.5",

@agurtovoy agurtovoy May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makeswift upgrade guides for 0.26 -> 0.28 transition:

@agurtovoy
agurtovoy marked this pull request as ready for review May 19, 2026 19:41
@agurtovoy
agurtovoy requested a review from a team as a code owner May 19, 2026 19:41
parthshahp
parthshahp approved these changes May 20, 2026
View reviewed changes

@parthshahp parthshahp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@agurtovoy
feat: enables client-side navigation in Makeswift builder
587f9f8 
Enabled by upgrading to the latest Makeswift runtime
@agurtovoy
agurtovoy force-pushed the aleksey/makeswift-builder-client-side-navigation branch from 7aff6ac to 587f9f8 Compare June 8, 2026 18:43
@parthshahp
parthshahp merged commit 097eea7 into integrations/makeswift Jun 9, 2026
24 of 27 checks passed
@parthshahp
parthshahp deleted the aleksey/makeswift-builder-client-side-navigation branch June 9, 2026 15:34
@github-actions github-actions Bot mentioned this pull request Jun 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chanceaclark chanceaclark chanceaclark left review comments
@fikrikarim fikrikarim fikrikarim left review comments
@jorgemoya jorgemoya jorgemoya approved these changes
@parthshahp parthshahp parthshahp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@agurtovoy @jorgemoya @chanceaclark @fikrikarim @parthshahp