Conversation
🦋 Changeset detectedLatest commit: a90d3e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
mfaris9
changed the title
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
chanceaclark
reviewed
May 7, 2026
chanceaclark
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
The checkbox-group branch in DynamicForm's schema builder does not call .optional() for non-required fields. This causes formField.required = true even when BigCommerce reports isRequired: false, putting field.required and formField.required out of sync for this one field type. No visible UI bug today (the render reads field.required directly), but could cause an issue down the line.
Refs: TRAC-275
Testing
Logged field.required vs formField.required for each rendered field on /register to verify the fix.
Before:
[DynamicFormField] {
name: 'customCustomer_Newsletter Topics (O)',
type: 'checkbox-group',
label: 'Newsletter Topics (O)',
'field.required': false,
'formField.required': true,
match: false
}
After:
[DynamicFormField] {
name: 'customCustomer_Newsletter Topics (O)',
type: 'checkbox-group',
label: 'Newsletter Topics (O)',
'field.required': false,
'formField.required': false,
match: true
}
Regression-tested the registration page with four custom fields added in the BC control panel. Field labels marked (O) are configured as optional in BC; (R) is configured as required. All rendered and submitted as expected. Screenshot attached.
Migration
No migration required. This was a simple internal bug fix.