Skip to content

fix(core): TRAC-277 translate Show more/less labels on product compare page#3009

Merged
bc-yevhenii-buliuk merged 1 commit into
canaryfrom
TRAC-277
May 12, 2026
Merged

fix(core): TRAC-277 translate Show more/less labels on product compare page#3009
bc-yevhenii-buliuk merged 1 commit into
canaryfrom
TRAC-277

Conversation

@bc-yevhenii-buliuk

Copy link
Copy Markdown
Contributor

What/Why?

This PR fixes the 'Show more' / 'Show less' labels in the Reveal component on the Product compare page.
The labels were hardcoded in English because showMoreLabel/showLessLabel props were not passed through the component chain (CompareSection → CompareCard → Reveal).

Testing

locally
before:
trac_277_bug

after:
trac_277_fixed

Migration

n/a

@bc-yevhenii-buliuk
bc-yevhenii-buliuk requested a review from a team as a code owner May 11, 2026 13:46
@vercel

vercel Bot commented May 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
catalyst Ready Ready Preview, Comment May 11, 2026 8:24pm

Request Review

@changeset-bot

changeset-bot Bot commented May 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e1163a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Report

Comparing against baseline from 37e0a7c (2026-05-11).

No bundle size changes detected.

@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Unlighthouse Performance Comparison — Vercel

Comparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores.

Summary Score

Aggregate score across all categories as reported by Unlighthouse.

Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Score 90 93 91 95

Category Scores

Category Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Performance 78 86 73 89
Accessibility 95 92 95 98
Best Practices 100 100 95 100
SEO 88 100 88 100

Core Web Vitals

Metric Prod Desktop Prod Mobile Preview Desktop Preview Mobile
LCP 3.4 s 4.1 s 4.2 s 3.8 s
CLS 0.001 0 0.04 0
FCP 1.2 s 1.1 s 1.2 s 1.2 s
TBT 0 ms 0 ms 0 ms 0 ms
Max Potential FID 50 ms 50 ms 50 ms 50 ms
Time to Interactive 3.4 s 4.3 s 4.4 s 4.1 s

Full Unlighthouse report →

Comment on lines +71 to +72
showMoreLabel = 'Show more',
showLessLabel = 'Show less',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've moved away from prop drilling, and instead we can simply call the t helper within this component. BUT merging as is, is also fine. 🍹

@bc-yevhenii-buliuk
bc-yevhenii-buliuk added this pull request to the merge queue May 12, 2026
Merged via the queue into canary with commit b47ace7 May 12, 2026
18 of 19 checks passed
@bc-yevhenii-buliuk
bc-yevhenii-buliuk deleted the TRAC-277 branch May 12, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants