TRAC-525: fix - client.ts not using Header object for default values#3018
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 05aa48b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
dd2511f to
56549d4
Compare
56549d4 to
0fd8063
Compare
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
0fd8063 to
eeb69da
Compare
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@bigcommerce/catalyst-client": minor | |||
There was a problem hiding this comment.
🍹 I'd say it's a patch, since we are technically fixing an intended functionality.
There was a problem hiding this comment.
You're right, I thought I changed that but I didn't. Updating.
eeb69da to
05aa48b
Compare
3 participants
What/Why?
Spreading plain object literals into the
fetchheadersfield left case-variant keys (e.g.Authorizationandauthorization) as distinct properties, whichfetchthen appended together into a single comma-joined value. Build the header set with aHeadersobject so overrides frombeforeRequestand per-callheadersreplace the defaults instead of duplicating them.Testing
Tested manually. Previously, passing in a header with
Authorizationwould append the key to theauthorizationheader rather than replacing it.Migration
No migration needed.