TRAC-469: add support for wae metrics#15
Merged
Merged
Conversation
rtalvarez
marked this pull request as ready for review
May 19, 2026 14:11
chanceaclark
approved these changes
May 19, 2026
|
|
||
| ### Notes | ||
|
|
||
| - The WAE aggregation window is 5 minutes. If your worker is low-traffic, expect series to disappear when traffic doesn't land in the window. |
There was a problem hiding this comment.
🍹 I would also say that it may be inaccurate as well. We've seen where KV reports "bad" metrics, as in high latency, due to a high-ish aggregation window.
Member
Author
There was a problem hiding this comment.
yeah, honestly we'll see how it goes. we can always make this value configurable in case we need to tweak it w/o code change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds support for fetching Analytics Engine metrics via the SQL API, and adds a converter into prometheus metrics, reading from
WAE_DATASET_SCRIPT_NAME_ENVdatastore.Generic implementation exposes
label,metric_typeandscript_name, assuming the worker knows the shape of their data.Type of Change
Testing
Verified the exporter is able to execute the API call
I have also verified that these show up in
localhost:8080/metricswith the right formatCode Quality
Before Submitting
Please ensure you have completed the following before submitting your PR:
# Run comprehensive tests make pr-testsIf the above command fails, please fix the issues before submitting your PR.
Additional Notes
Add any other context about the pull request here.