Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project-7525: [DO NOT MERGE] Feature branch for the new returns flow #2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Project-7525: [DO NOT MERGE] Feature branch for the new returns flow #2667
Changes from 44 commits
330b8e9ac9bf8aaf49f3e14208d924283276c76072fe09e792d3cdbc963636aab8f7d5bfe4b85c855cfeb99549204f5eef0ee5349fe8ed9346ddad6d9fa0749f59f8d74042bbb7519508c78e1f3bfab15156d3c2521b10d381223d2d58e1eb73b93b095fd05baca54dac7595238101ea730feae5b4f55f702765d87f3cd34dca697e85a5340f0baeb1570281cac1afefa882b48a15ff620ca5bc4a8e4e70092e69fd279390b49797e94a29199a9c879ccb769d217a72d067100e9386f632162bbFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submit re-enabled without validation
Medium Severity
After a failed or errored
createReturnrequest, the submit handler’sfinallyblock setsreturn-new-submitBtnto enabled without callingupdateSubmitState(), so the button can stay clickable when no line items have quantity, resolution, and reason filled in.Reviewed by Cursor Bugbot for commit 34bc18e. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API errors never shown
Medium Severity
getErrorMessagescollects GraphQL error text, butshowErroronly reveals the static error box and never writes those messages into the DOM, so shoppers always see the generic copy.Reviewed by Cursor Bugbot for commit 4a8e4e7. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional note omitted from payload
Medium Severity
The create-return page collects an “Additional Note” in
data-new-return-note, butbuildReturnInput()never reads that field, so shopper notes are dropped and never sent with thecreateReturnmutation.Additional Locations (1)
templates/pages/create-return.html#L102-L108Reviewed by Cursor Bugbot for commit bcea92e. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guest redirect ignores locale path
Medium Severity
After a successful guest session, navigation uses a root-absolute
/create-return/{orderId}URL, which drops the active language subfolder on multi-language storefronts and can land shoppers on the wrong locale or a 404.Reviewed by Cursor Bugbot for commit 20ca5bc. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GraphQL fetch omits base URL
Medium Severity
New returns flows call
fetch('/graphql', …)with a root-absolute URL, unlike other theme API usage that passessecureBaseUrl, so GraphQL may miss the correct prefixed path on multi-language storefronts.Additional Locations (1)
assets/js/theme/create-return.js#L92-L93Reviewed by Cursor Bugbot for commit 99a9c87. Configure here.
Uh oh!
There was an error while loading. Please reload this page.