fix: preserve null service values in find() resolution#49
Draft
TomA-R wants to merge 1 commit into
Draft
Conversation
find() returned null both for a missing entry and for an entry that resolves to null, so the Injector treated a present-but-null dependency as absent and threw instead of supplying null to a nullable parameter. Add a FindResult::NotFound sentinel so a present null is kept distinct from absence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find()returnednullboth for a missing entry and for an entry that resolves tonull, so the Injector treated a present-but-null dependency as absent and threw instead of supplyingnullto a nullable parameter.Adds a
FindResult::NotFoundsentinel sofind()keeps a presentnulldistinct from absence. Tests cover both Injector resolution paths and the adapter.