Video producer tool using benchmarks in BDV#136
Closed
mzouink wants to merge 29 commits into
Closed
Conversation
mkitti
reviewed
Nov 28, 2022
Collaborator
mkitti
left a comment
mkitti
left a comment
There was a problem hiding this comment.
I apparently started to review a long time ago. I'm just going to submit it now.
Comment on lines
+747
to
+749
| final String fn = "/Users/pietzsch/workspace/data/111010_weber_full.xml"; | ||
| // final String fn = "/Users/pietzsch/workspace/data/111010_weber_full.xml"; |
| <dependency> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| <version>2.8.5</version> |
Collaborator
There was a problem hiding this comment.
Could we make the version a property? Any reason not to use 2.8.6 like in parent POM?
Comment on lines
+7
to
+11
| ### Install: | ||
| `$ ./install.sh` | ||
|
|
||
| ### Run: | ||
| `$ ./bdv INPUT_PATH` |
Collaborator
There was a problem hiding this comment.
Mention Windows install instructions or recommend WSL2.
| import org.scijava.ui.behaviour.io.yaml.YamlConfigIO; | ||
| import org.scijava.ui.behaviour.util.Actions; | ||
|
|
||
| import javax.swing.*; |
Collaborator
There was a problem hiding this comment.
Are we doing wildcards in the imports now?
Comment on lines
+3
to
+4
| import javax.swing.*; | ||
| import java.awt.*; |
| import javax.swing.*; | ||
| import javax.swing.border.Border; | ||
| import javax.swing.border.TitledBorder; | ||
| import java.awt.*; |
Comment on lines
+8
to
+9
| import javax.swing.*; | ||
| import java.awt.*; |
| import bdv.viewer.animate.SimilarityTransformAnimator; | ||
| import net.imglib2.realtransform.AffineTransform3D; | ||
|
|
||
| import javax.swing.*; |
Author
|
@mkitti i created a new repo : https://github.com/JaneliaSciComp/bigdataviewer-core-movie-producer |
Member
|
this is replaced by #151 now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a tool for video producing using BDV
I used the code made by @axtimwalde in hotknife and I embedded it in a GUI. It was a request from @StephanPreibisch
Here is a small tutorial on how to use it: https://youtu.be/vXu4ZOboEio
