Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options to NewWithDefaults, update bool #20

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

emar-kar
Copy link
Contributor

@emar-kar emar-kar commented Mar 9, 2025

This update adds options into NewWithDefaults function and makes boolean check case insensitive

  • includes small docs changes and comments update

@bigkevmcd
Copy link
Owner

@emar-kar Can you rebase and fix the conflicts for this?

@emar-kar
Copy link
Contributor Author

@bigkevmcd yeah, sure, will do today, a little bit later

@bigkevmcd
Copy link
Owner

I'm not so sure about this change.

While I appreciate the intent, this behaviour is different from the Python ConfigParser?

https://docs.python.org/3/library/configparser.html#configparser.ConfigParser.getboolean

Having said that, it doesn't seem to be a massive deviation, let me think about this a bit more.

@bigkevmcd
Copy link
Owner

The NewWithOptions change looks good tho'.

@bigkevmcd bigkevmcd merged commit a679eef into bigkevmcd:main Mar 11, 2025
1 check passed
@emar-kar emar-kar deleted the le/add-opts-nwd branch March 11, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants