Skip to content

Fix checkbox trigger specifier when used with checkboxes #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix checkbox trigger specifier when used with checkboxes #2896

wants to merge 1 commit into from

Conversation

@jsonn
Copy link
Contributor

@jsonn jsonn commented Sep 11, 2024 •
edited
Loading

Description

Unlike other form elements, checkbox elements will return on whether or not they are currently ticked. Explicitly handle this by checking for the tag name and type and then use the checked property.

Testing

A new test case is included, failing before.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

Note: this PR is on top of #2893

@jsonn jsonn changed the base branch from master to dev September 11, 2024 22:59
@Telroshan Telroshan added bug Something isn't working under discussion Issues that are being considered but require further alignment labels Sep 12, 2024
@Telroshan
Copy link
Collaborator

Telroshan commented Sep 12, 2024

Note: I'm labelling this as "under discussion" until #2891 is processed, as the latter includes some changes that this PR depends on.
If and when #2891 is merged in, this PR's diff will be smaller thus easier to review.

@jsonn
Fix changed trigger specifier with checkbox nodes
1f24c6c 
<input type="checkbox"> is special in that it shows up with a value of
"on", even if it is not checked. Introduce a helper function for getting
the effective value of a node by handling this pecularity.
@jsonn
Copy link
Contributor Author

jsonn commented Nov 15, 2025

Rebased on current dev, should be easy to merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working under discussion Issues that are being considered but require further alignment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsonn @Telroshan