Skip to content

Fix some external links (#3157) #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

xehrad
Copy link
Contributor

@xehrad xehrad commented Jan 30, 2025

I agree. I had tried to arrange the list in alphabetical order.

json-enc converts an HTML form into a simple {input.name: input.value} map, whereas form-json allows input.name values containing . to be interpreted as paths for nested structures.
It also supports <input type="file">, converting file inputs to Base64-encoded data.

json-enc

<form hx-ext="json-enc">
  <input name="user.age" value="18" type=number" />
  <input type="file" name="document">
</form>

<!-- Submission:
{
  "user.age":  "18"
}
-->

form-json

<form hx-ext="form-json">
  <input name="user.age" value="18" type=number" />
  <input type="file" name="document">
</form>

<!-- Submission:
{
  "user":  {
    "age":  18
  },
  "document": {
    "type": "application/pdf",
    "name": "file.pdf",
    "body": "SSBtdXN0IG5vdCBmZWFyLlxuRmVhciBpcyB0aGUgbWluZC1raWxsZXIuCg=="
  }
-->

Checklist

  • [*] I have read the contribution guidelines
  • [*] I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • [*] This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • [*] I ran the test suite locally (npm run test) and verified that it succeeded

@xehrad xehrad mentioned this pull request Jan 30, 2025
@Telroshan Telroshan added documentation Improvements or additions to documentation extension Consideration for an extension labels Jan 31, 2025
@Telroshan Telroshan merged commit 6ea1029 into bigskysoftware:master Jan 31, 2025
1 check passed
emilhem pushed a commit to emilhem/htmx that referenced this pull request Feb 10, 2025
@MichaelWest22
Copy link
Collaborator

Just noticed this extension we now link to happens to have an incompatible GPLv3 license which could cause legal issues for any user linking to it inside their project. @xehrad is there a reason this library has to be GPL? The vast majority of web development is not compatible with GPL licensed libraries. There is the LGPL which is better but it still has some unknowns and compliance issues. I would recommend re-licensing under a similar license to htmx like https://github.com/bigskysoftware/htmx/blob/master/LICENSE BSD-0 as this is much more friendly for web applications to consume.

@xehrad
Copy link
Contributor Author

xehrad commented Mar 25, 2025

Just noticed this extension we now link to happens to have an incompatible GPLv3 license which could cause legal issues for any user linking to it inside their project. @xehrad is there a reason this library has to be GPL? The vast majority of web development is not compatible with GPL licensed libraries. There is the LGPL which is better but it still has some unknowns and compliance issues. I would recommend re-licensing under a similar license to htmx like https://github.com/bigskysoftware/htmx/blob/master/LICENSE BSD-0 as this is much more friendly for web applications to consume.

Thanks for catching this! You're right that GPLv3 could introduce compatibility issues for many users. I’ve gone ahead and changed the license to Zero-Clause BSD (0BSD), which aligns with htmx’s license and ensures maximum flexibility for web development.

Let me know if you have any other concerns!

@MichaelWest22
Copy link
Collaborator

@xehrad great thanks! I think your readme.md may need updating as well as you state the license in here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation extension Consideration for an extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants